Reintroduce TILEDB_STATIC under a deprecation warning.
#4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Feb 15, 2024
cmake/Options/BuildOptions.cmake
Outdated
| @@ -40,6 +40,15 @@ option(CMAKE_EXPORT_COMPILE_COMMANDS "cmake compile commands" ON) | |||
|
|
|||
| set(TILEDB_INSTALL_LIBDIR "" CACHE STRING "If non-empty, install TileDB library to this directory instead of CMAKE_INSTALL_LIBDIR.") | |||
|
|
|||
| if (DEFINED TILEDB_STATIC) | |||
| message(DEPRECATION "TILEDB_STATIC is deprecated and will be removed in a future version. Use BUILD_SHARED_LIBS INSTEAD. Building both static and shared libraries is no longer available.") | |||
There was a problem hiding this comment.
We should say which version.
There was a problem hiding this comment.
"2.28 (third quarter of 2024)" seems reasonable. We should consider doing the update PRs ourselves for obvious public projects (freebsd and mingw-w64 at least).
|
The bootstrap scripts don't need any changes, they still support these options and emit warnings if specified. |
ihnorton
approved these changes
Feb 16, 2024
cmake/Options/BuildOptions.cmake
Outdated
| @@ -40,6 +40,15 @@ option(CMAKE_EXPORT_COMPILE_COMMANDS "cmake compile commands" ON) | |||
|
|
|||
| set(TILEDB_INSTALL_LIBDIR "" CACHE STRING "If non-empty, install TileDB library to this directory instead of CMAKE_INSTALL_LIBDIR.") | |||
|
|
|||
| if (DEFINED TILEDB_STATIC) | |||
| message(DEPRECATION "TILEDB_STATIC is deprecated and will be removed in a future version. Use BUILD_SHARED_LIBS INSTEAD. Building both static and shared libraries is no longer available.") | |||
There was a problem hiding this comment.
"2.28 (third quarter of 2024)" seems reasonable. We should consider doing the update PRs ourselves for obvious public projects (freebsd and mingw-w64 at least).
KiterLuc
pushed a commit
that referenced
this pull request
Feb 16, 2024
--- TYPE: BUILD DESC: Reintroduce the `TILEDB_STATIC` option under a deprecation warning. (cherry picked from commit 14e99dd)
KiterLuc
added a commit
that referenced
this pull request
Feb 16, 2024
…on warning. (#4732) (#4738) Backport 14e99dd from #4732. --- TYPE: BUILD DESC: Reintroduce the `TILEDB_STATIC` option under a deprecation warning. Co-authored-by: Theodore Tsirpanis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: BUILD
DESC: Reintroduce the
TILEDB_STATICoption under a deprecation warning.