Fix bug with new minio behavior #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #40963: Fix S3 errors on macOS S3 CI runners. |
KiterLuc
approved these changes
Feb 14, 2024
abigalekim
pushed a commit
that referenced
this pull request
Feb 16, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior
This was referenced Feb 21, 2024
KiterLuc
pushed a commit
that referenced
this pull request
Feb 21, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior (cherry picked from commit e11fe82)
KiterLuc
pushed a commit
that referenced
this pull request
Feb 21, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior (cherry picked from commit e11fe82)
KiterLuc
pushed a commit
that referenced
this pull request
Feb 21, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior (cherry picked from commit e11fe82)
|
For the record the minio change happened in minio/minio#19034. |
KiterLuc
pushed a commit
that referenced
this pull request
Feb 21, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior (cherry picked from commit e11fe82)
KiterLuc
added a commit
that referenced
this pull request
Feb 22, 2024
Backport e11fe82 from #4725. --- TYPE: BUG DESC: Fix bug with new minio behavior. Co-authored-by: Paul J. Davis <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Feb 22, 2024
Backport e11fe82 from #4725. --- TYPE: BUG DESC: Fix bug with new minio behavior. Co-authored-by: Paul J. Davis <[email protected]>
Shelnutt2
pushed a commit
that referenced
this pull request
Apr 21, 2024
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior (cherry picked from commit e11fe82)
Shelnutt2
added a commit
that referenced
this pull request
Apr 21, 2024
The new MinIO behavior was accounted for in dev/2.20 and newer. Instead of backporting the new S3 behavior we are pinning MinIO. The mentioned update took place in #4725
Shelnutt2
added a commit
that referenced
this pull request
Apr 21, 2024
The new MinIO behavior was accounted for in dev/2.20 and newer. Instead of backporting the new S3 behavior we are pinning MinIO. The mentioned update took place in #4725
Shelnutt2
added a commit
that referenced
this pull request
Apr 21, 2024
…4899) The [new MinIO behavior](minio/minio#19034) was accounted for in dev/2.20 and newer. Instead of backporting the new S3 behavior we are pinning MinIO. The mentioned update took place in #4725 --- TYPE: NO_HISTORY DESC: Change CI to use a pinned version of MinIO before breaking behavior on deletes was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered.
TYPE: BUG
DESC: Fix bug with new minio behavior