Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize sparse reads when full non empty domain is requested. #4710

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

KiterLuc
Copy link
Contributor

@KiterLuc KiterLuc commented Feb 9, 2024

This change allows to optimize sparse reads where the only range set covers the non-empty domain of the fragments to be read. This is the case for python.


TYPE: IMPROVEMENT
DESC: Optimize sparse reads when full non empty domain is requested.

This change allows to optimize sparse reads where the only range set covers the non-empty domain of the fragments to be read. This is the case for python.

---
TYPE: IMPROVEMENT
DESC: Optimize sparse reads when full non empty domain is requested.
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@KiterLuc KiterLuc merged commit 437340d into dev Feb 9, 2024
64 checks passed
@KiterLuc KiterLuc deleted the lr/reset-default-ranges branch February 9, 2024 15:14
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
This change allows to optimize sparse reads where the only range set
covers the non-empty domain of the fragments to be read. This is the
case for python.

---
TYPE: IMPROVEMENT
DESC: Optimize sparse reads when full non empty domain is requested.

(cherry picked from commit 437340d)
KiterLuc added a commit that referenced this pull request Feb 9, 2024
KiterLuc added a commit that referenced this pull request Feb 9, 2024
…in 2.20. (#4718)

Revert
437340d
from #4710.

---
TYPE: NO_HISTORY
DESC: Revert optimize sparse reads when full non empty domain is
requested in 2.20.
KiterLuc added a commit that referenced this pull request Feb 10, 2024
This was introduced in #4710. In that PR, we could try to use the non empty domain of an array with no fragments, which is empty. This should fix python and R nightlies.

---
TYPE: NO_HISTORY
DESC: Don't use non empty domain on empty array.
KiterLuc added a commit that referenced this pull request Feb 10, 2024
This was introduced in #4710.
In that PR, we could try to use the non empty domain of an array with no
fragments, which is empty. This should fix python and R nightlies.

---
TYPE: NO_HISTORY
DESC: Don't use non empty domain on empty array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants