-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize sparse reads when full non empty domain is requested. #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to optimize sparse reads where the only range set covers the non-empty domain of the fragments to be read. This is the case for python. --- TYPE: IMPROVEMENT DESC: Optimize sparse reads when full non empty domain is requested.
davisp
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
This change allows to optimize sparse reads where the only range set covers the non-empty domain of the fragments to be read. This is the case for python. --- TYPE: IMPROVEMENT DESC: Optimize sparse reads when full non empty domain is requested. (cherry picked from commit 437340d)
KiterLuc
added a commit
that referenced
this pull request
Feb 9, 2024
…ain is requested. (#4715) Backport 437340d from #4710. Co-authored-by: KiterLuc <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Feb 10, 2024
This was introduced in #4710. In that PR, we could try to use the non empty domain of an array with no fragments, which is empty. This should fix python and R nightlies. --- TYPE: NO_HISTORY DESC: Don't use non empty domain on empty array.
KiterLuc
added a commit
that referenced
this pull request
Feb 10, 2024
This was introduced in #4710. In that PR, we could try to use the non empty domain of an array with no fragments, which is empty. This should fix python and R nightlies. --- TYPE: NO_HISTORY DESC: Don't use non empty domain on empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to optimize sparse reads where the only range set covers the non-empty domain of the fragments to be read. This is the case for python.
TYPE: IMPROVEMENT
DESC: Optimize sparse reads when full non empty domain is requested.