Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random_label in favor of uuid. #4709

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

KiterLuc
Copy link
Contributor

@KiterLuc KiterLuc commented Feb 9, 2024

The random label work broke the python tests because it can generate the same URI under certain conditions.


TYPE: NO_HISTORY
DESC: Remove random_label in favor of uuid.

The random label work broke the python tests because it can generate the same URI under certain conditions.

---
TYPE: NO_HISTORY
DESC: Remove random_label in favor of uuid.
@KiterLuc KiterLuc merged commit 2f03f0c into dev Feb 9, 2024
64 checks passed
@KiterLuc KiterLuc deleted the lr/fragment-name-uuid branch February 9, 2024 13:12
KiterLuc added a commit that referenced this pull request Feb 9, 2024
The random label work broke the python tests because it can generate the
same URI under certain conditions.

---
TYPE: NO_HISTORY
DESC: Remove random_label in favor of uuid.

(cherry picked from commit 2f03f0c)
@ihnorton
Copy link
Member

ihnorton commented Feb 9, 2024

x-ref #4589 for future tracking.

@eric-hughes-tiledb
Copy link
Contributor

it can generate the same URI under certain conditions

Where's the defect report? If that's true, it means there's either (1) a defect in random_label or (2) it's being used incorrectly.

KiterLuc added a commit that referenced this pull request Feb 9, 2024
…#4713)

Backport
2f03f0c
from #4709.

---
TYPE: NO_HISTORY
DESC: Remove random_label in favor of uuid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants