Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore compile_commands.json #4680

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Ignore compile_commands.json #4680

merged 1 commit into from
Jan 30, 2024

Conversation

davisp
Copy link
Contributor

@davisp davisp commented Jan 29, 2024

This is just a quality of life so that developers can symlink compile_commands.json to wherever they place their build directory. The reaoning for this is that a number of editor extensions use this file to configure their LSP interface for improved editor support.


TYPE: NO_HISTORY
DESC: Ignore compile_commands.json

This is just a quality of life so that developers can symlink
compile_commands.json to wherever they place their build directory. The
reaoning for this is that a number of editor extensions use this file to
configure their LSP interface for improved editor support.
@davisp davisp requested a review from KiterLuc January 29, 2024 18:20
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (but this should only be generated in the build directory...)

@davisp
Copy link
Contributor Author

davisp commented Jan 29, 2024

+1 (but this should only be generated in the build directory...)

Yeah, I'm probably going to open an issue on the editor extension I'm using to make it configurable, but for now they require it to be in the project root for discovery. I just got annoyed seeing it in git status output so added the ignore. It seemed fine to me because we'll never ever want to commit that regardless.

@KiterLuc KiterLuc merged commit ee6c1bc into dev Jan 30, 2024
64 checks passed
@KiterLuc KiterLuc deleted the pd/ignore-compile-commands branch January 30, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants