-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make porting tiledb_unit integration tests to REST CI easier #4678
Conversation
This pull request has been linked to Shortcut Story #37953: Augment current REST-CI tests around array open and running queries.. |
0245549
to
a20b900
Compare
Please ask me to review this when it is ready. |
5945774
to
37dbdca
Compare
514b9a5
to
a1c4a39
Compare
872f8fd
to
08752f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green, nice work 👍 REST CI will fail since this PR removes bootstrap flags being used in those workflows.
If you want to test this PR against TileDB-REST-CI we can update the ref parameter in ci-rest.yml to point to a different branch on TileDB-REST-CI. We would definitely want to revert that change before merging though. If you would like to test this way and run into issues there or want me to spin up a branch on TileDB-REST-CI for testing LMK, happy to help.
tiledb/sm/c_api/tiledb.cc
Outdated
if (uri.is_tiledb()) { | ||
throw std::invalid_argument( | ||
"Getting the encryption type of remote arrays is not supported."); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we return no encryption instead of failing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiterLuc opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should keep logic out of the C-api. Can this be moved into the C++ side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of a better place to have this logic. In the past this could fit in a StorageManager::get_array_encryption_type
function, but we want to stop using StorageManager
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to array_get_encryption
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh there was already such method, great.
4249e85
to
3cccacb
Compare
21b3d8b
to
7d128ca
Compare
Thanks for the idea and the pointers! I did that (and reverted) against my Tiledb-REST-CI branch: https://github.com/TileDB-Inc/TileDB-REST-CI/pull/17 |
if (uri.is_tiledb()) { | ||
throw std::invalid_argument( | ||
"Getting the encryption type of remote arrays is not supported."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (uri.is_tiledb()) { | |
throw std::invalid_argument( | |
"Getting the encryption type of remote arrays is not supported."); | |
} | |
if (uri.is_tiledb()) { | |
*encryption_type = EncryptionType::NO_ENCRYPTION; | |
return Status::Ok(); | |
} |
f2be9f8
to
e49182f
Compare
c472fa7
to
12a46cb
Compare
c4a5e57
to
ecaec9c
Compare
This passes the `cloud_rest_ref` parameter to pin to a 2.18 compatible version so that the compilation and linking works as expected, including using the older pre-vfs option that came in #4678 . --- TYPE: NO_HISTORY DESC: pin ci-rest job to 2.18 compatible version
This PR groups some improvements on testing infra for REST tests:
VFSTestSetup
as an easy way to set up an integration test intiledb_unit
for all VFSs and REST.--enable-rest-tests
bootstrap and correspondingTILEDB_TESTS_ENABLE_REST
options.tiledb_unit
tests to run on REST CI, [non-rest] for tests that don't apply to REST, and [rest-fails] to tests that should be run on REST but fail because of issues logged here: https://app.shortcut.com/tiledb-inc/story/40489/issues-found-while-running-tiledb-unit-core-tests-against-rest-cloud-serverNote: REST-CI runner needs to be adapted after this is merged, but it's in a separate repo if I understand well. Also an extra runner will be added to test Query v3 that will be setting
use_refactored_array_open_and_query_submit
config totrue
by default and run all [rest] tests.TYPE: NO_HISTORY
DESC: Make porting tiledb_unit integration tests to REST CI easier