Remove serialization non C.41 constructors from index_read_state_from_capnp. #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #40051: Remove serialization non C.41 constructors from index_read_state_from_capnp.. |
KiterLuc
suggested changes
Jan 26, 2024
abigalekim
changed the title
KiterLuc
reviewed
Jan 30, 2024
| */ | ||
| ReadState* read_state(); | ||
| ReadState& read_state(); |
There was a problem hiding this comment.
Audit the code and see if the only reason we need this is because we want to update the read state. If so, let's rename to void set_read_state(...)
KiterLuc
reviewed
Feb 1, 2024
| * Return whether the tiles that will be processed are loaded in memory. | ||
| * @return Done adding result tiles. | ||
| */ | ||
| const bool& done_adding_result_tiles() const { |
There was a problem hiding this comment.
Suggested change
| const bool& done_adding_result_tiles() const { | |
| bool done_adding_result_tiles() const { |
| * @param done_adding_result_tiles Done adding result tiles. | ||
| * @return void | ||
| */ | ||
| inline void set_done_adding_result_tiles(bool done_adding_result_tiles) { |
There was a problem hiding this comment.
This should only be changed from false to true... Remove the parameter.
There was a problem hiding this comment.
This isn't true--this code is in sparse_index_reader_base.cc.
Status SparseIndexReaderBase::load_initial_data() {
if (initial_data_loaded_) {
return Status::Ok();
}
auto timer_se = stats_->start_timer("load_initial_data");
read_state_.set_done_adding_result_tiles(false);Additionally, there is code where this occurs in sparse_global_order_reader.cc and sparse_unordered_with_dups_reader.cc:
read_state_.set_done_adding_result_tiles(done_adding_result_tiles);
KiterLuc
force-pushed
the
abigalekim/sc-40051/remove-serialization-non-c-41-constructors
branch
from
601f451 to
a7a5909
Compare
KiterLuc
force-pushed
the
abigalekim/sc-40051/remove-serialization-non-c-41-constructors
branch
from
a7a5909 to
695399f
Compare
KiterLuc
approved these changes
Feb 6, 2024
KiterLuc
deleted the
abigalekim/sc-40051/remove-serialization-non-c-41-constructors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made index_read_state_from_capnp C41 compliant.
TYPE: NO_HISTORY
DESC: Remove serialization non C.41 constructors from index_read_state_from_capnp