Return a fresh handle from tiledb_field_channel.
#4637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes double freeing if the user also frees the handle, as they are expected to do.
…query instead of a query handle.
|
This pull request has been linked to Shortcut Story #39123: tiledb_field_channel returns the same handle and is prone to double freeing.. |
eric-hughes-tiledb
suggested changes
Jan 30, 2024
|
Opened SC-40347 for the CI failure. Because the failure is clearly not related to this PR I don't think investigating the failure should block this. |
|
Closing in favor of #4786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-39123
tiledb_field_channelwas always returning the same channel for a field and freed it when the field itself was freed, resulting in double freeing if the user also freed that handle, as the expectation for managing handles is. This PR changes the function to always create a different handle.Validated by successfully running
unit_capi_query_fieldon Windows in Debug mode (it was failing previously with a segfault because of the aforementioned double freeing).By searching for the regex
tiledb_\w+_t\*in all.cppand.hfiles and inspecting the results, I did not notice any similar case elsewhere in the codebase.TYPE: BUG
DESC: Return a fresh handle from
tiledb_field_channel, preventing double freeing.