Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include array to cpp_api type.h #4504

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add include array to cpp_api type.h #4504

merged 1 commit into from
Nov 9, 2023

Conversation

lums658
Copy link
Contributor

@lums658 lums658 commented Nov 9, 2023

The file type.h in tiledb/sm/cpp_api used std::array but does not #include <array>. This causes failure when compiling with clang++-14 on ubuntu.

Added #include <array> to tiledb/sm/cpp_api/type.h.

TYPE: BUG
DESC: Added #include <array> to tiledb/sm/cpp_api/type.h.

@lums658 lums658 requested review from ihnorton and KiterLuc November 9, 2023 17:48
davisp
davisp approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a qudrupple take to realize this is the C++ stdlib header and not a reference to our Array header. 😅

+1

@KiterLuc KiterLuc merged commit 9acc602 into dev Nov 9, 2023
55 checks passed
@KiterLuc KiterLuc deleted the lums/tmp/type_array branch November 9, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@davisp davisp davisp approved these changes

@KiterLuc KiterLuc Awaiting requested review from KiterLuc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lums658 @davisp @ihnorton @KiterLuc