Add Enumeration REST CI Tests #4473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found while debugging the array schema serialization bug. Returning `TILEDB_ERR` here prevents the exception wrapper from reporting the exception that was encountered. The fix is obviously to just rethrow the exception instead.
This is an obvious oversight from me when adding tests in the original PR. I managed to test array schema evolution for extending enumerations but never thought to add basic schema serialization tests with empty enmerations.
Making these a separate PR that will be merged after the development branch of TileDB-Cloud-REST. If we included this in the same PR as adding the implementation we'd fail all the REST CI checks. I am open to suggestions on how to make this less terrible.
|
This pull request has been linked to Shortcut Story #36308: Add CI Rest tests for Enumerations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the TileDB-Cloud-REST has been updated with the Enumeration routes we can finally merge the REST tests for CI.
TYPE: NO_HISTORY
DESC: Add Enumeration REST CI Tests.