Fix serialization of empty enumerations #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found while debugging the array schema serialization bug. Returning `TILEDB_ERR` here prevents the exception wrapper from reporting the exception that was encountered. The fix is obviously to just rethrow the exception instead.
|
This pull request has been linked to Shortcut Story #36299: Fix serialization of empty enumerations. |
davisp
force-pushed
the
pd/sc-36299/fix-empty-enumeration-serialization
branch
2 times, most recently
from
6ea641b to
bc615c3
Compare
This is an obvious oversight from me when adding tests in the original PR. I managed to test array schema evolution for extending enumerations but never thought to add basic schema serialization tests with empty enmerations.
davisp
force-pushed
the
pd/sc-36299/fix-empty-enumeration-serialization
branch
from
bc615c3 to
7973a65
Compare
johnkerl
approved these changes
Oct 31, 2023
|
In addition to the unit-test coverage on this PR: validated in sandbox checkout as discussed in team Slack. |
|
Tested this branch with REST server and works |
KiterLuc
reviewed
Nov 1, 2023
| @@ -3595,7 +3595,7 @@ int32_t tiledb_deserialize_array_schema( | |||
| } catch (...) { | |||
| delete *array_schema; | |||
| *array_schema = nullptr; | |||
| return TILEDB_ERR; | |||
| throw; | |||
There was a problem hiding this comment.
Is this change intended? Should we use tapi::CAPIStatusException?
KiterLuc
approved these changes
Nov 1, 2023
This was referenced Nov 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
This was an obvious oversight in the original PR. I managed to cover enumeration extension serialization but forgot to include serialization of empty arrays. --- TYPE: BUG DESC: Fix serialization of empty enumerations (cherry picked from commit 9163edf)
KiterLuc
pushed a commit
that referenced
this pull request
Nov 1, 2023
This was an obvious oversight in the original PR. I managed to cover enumeration extension serialization but forgot to include serialization of empty arrays. --- TYPE: BUG DESC: Fix serialization of empty enumerations (cherry picked from commit 9163edf)
KiterLuc
pushed a commit
that referenced
this pull request
Nov 1, 2023
This was an obvious oversight in the original PR. I managed to cover enumeration extension serialization but forgot to include serialization of empty arrays. --- TYPE: BUG DESC: Fix serialization of empty enumerations
KiterLuc
pushed a commit
that referenced
this pull request
Nov 1, 2023
Backport 9163edf from #4472. --- TYPE: NO_HISTORY Co-authored-by: Paul J. Davis <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Nov 1, 2023
Backport 9163edf from #4472. --- TYPE: NO_HISTORY Co-authored-by: Paul J. Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an obvious oversight in the original PR. I managed to cover enumeration extension serialization but forgot to include serialization of empty arrays.
TYPE: BUG
DESC: Fix serialization of empty enumerations