Aggregates: allow aggregates pipeline the processing of full tiles. #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new aggregate_full_tile interface to iaggregator so that we can later use the data in the fragment metadata to improve aggregation performance. The data is packaged in the new FullTileData class, which will later be produced by the fragment metadata. Note that this only implements the aggregators side of the work... Reader/FragmentMetadata changes will follow. --- TYPE: FEATURE DESC: Aggregates: allow aggregates pipeline the processing of full tiles.
robertbindar
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks! The implementation seems sound, thanks for keeping this code tidy with the new update_data. Can we do anything with the "Full Tile" naming? I have a problem with it in the sense that it doesn't tell me at all that the data is coming from fragment metadata, so unless you're in the reader/fragmeta code and you see where the data originates from, you have no idea that aggregate_data and aggregate_full_tile operate on two completely different data sources that have very different operating costs.
KiterLuc
force-pushed
the
lr/aggregates-full-tiles
branch
from
38cc469 to
d9ad5bc
Compare
KiterLuc
force-pushed
the
lr/aggregates-full-tiles
branch
from
d9ad5bc to
df91a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new aggregate_full_tile interface to iaggregator so that we can later use the data in the fragment metadata to improve aggregation performance. The data is packaged in the new FullTileData class, which will later be produced by the fragment metadata.
Note that this only implements the aggregators side of the work... Reader/FragmentMetadata changes will follow.
TYPE: FEATURE
DESC: Aggregates: allow aggregates pipeline the processing of full tiles.