Aggregates: combine sum/mean aggregators. #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33763: [Refactor] Aggregates: final removal of duplicated code.. |
This combines the sum and mean aggregators into base class. --- TYPE: IMPROVEMENT DESC: Aggregates: combine sum/mean aggregators.
KiterLuc
force-pushed
the
lr/aggregates-remove-duplicate-code/ch33763
branch
from
fb9dec5 to
6dbae23
Compare
robertbindar
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Looks excellent with a minor comment that validity_value_ both here and in min/max will need to become an atomic if either a) we change its type to something bigger than uint8 b) we add code that inspects partial results, i.e. reading the variable value before all writers are done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the sum and mean aggregators into base class.
TYPE: IMPROVEMENT
DESC: Aggregates: combine sum/mean aggregators.