Aggregates: change to use size instead of min cell/max cell. #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33760: [Refactor] Aggregates: use benchmarks to refactor computation class.. |
bekadavis9
approved these changes
Oct 18, 2023
KiterLuc
commented
Oct 18, 2023
KiterLuc
force-pushed
the
lr/compute-class-refactor/ch33760
branch
2 times, most recently
from
d9e1104 to
085075c
Compare
This changes the AggregateWithCount class to compute using a size only instead of min cell/max cell. --- TYPE: IMPROVEMENT DESC: Aggregates: change to use size instead of min cell/max cell.
KiterLuc
force-pushed
the
lr/compute-class-refactor/ch33760
branch
2 times, most recently
from
e285751 to
6fc0d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the AggregateWithCount class to compute using a size only instead of min cell/max cell.
TYPE: IMPROVEMENT
DESC: Aggregates: change to use size instead of min cell/max cell.