Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregators: adding benchmark for aggregate_with_count class. #4420

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

KiterLuc
Copy link
Contributor


TYPE: IMPROVEMENT
DESC: Aggregators: adding benchmark for aggregate_with_count class.

@shortcut-integration
Copy link

@KiterLuc KiterLuc requested a review from bekadavis9 October 13, 2023 15:20
@KiterLuc KiterLuc force-pushed the lr/bench-aggregators/ch33758 branch from 0ec8c7d to aa6579d Compare October 13, 2023 16:51
Copy link
Contributor

@bekadavis9 bekadavis9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, there's opportunity to use the in-development PRNG. Else, PR LGTM

@KiterLuc KiterLuc force-pushed the lr/bench-aggregators/ch33758 branch from aa6579d to d8502b6 Compare October 16, 2023 20:54
---
TYPE: IMPROVEMENT
DESC: Aggregators: adding benchmark for aggregate_with_count class.
@KiterLuc KiterLuc force-pushed the lr/bench-aggregators/ch33758 branch from d8502b6 to 05b4687 Compare October 16, 2023 21:32
@KiterLuc KiterLuc merged commit 5200bbb into dev Oct 17, 2023
@KiterLuc KiterLuc deleted the lr/bench-aggregators/ch33758 branch October 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants