Fixup query condition set membership creation API #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34819: Remove default |
During review there was some confusion over having a default of `TILEDB_IN` when creating set membership query conditions. The confusion also prompted me to realize that we may have other types of query conditions in the future that take a list of values that are not set membership related which makes having the `TILEDB_IN` default even less well designed. Unfortunately, I forgot to remove the default from the std::string version of that function. @eddelbuettel also kindly pointed out that I forgot to document the `op` paramter which I've also added.
davisp
force-pushed
the
pd/sc-34819/fix-qc-set-cpp-api
branch
from
e92c613 to
9ff5ad0
Compare
|
Note: this needs a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During review there was some confusion over having a default of
TILEDB_INwhen creating set membership query conditions. The confusion also prompted me to realize that we may have other types of query conditions in the future that take a list of values that are not set membership related which makes having theTILEDB_INdefault even less well designed.Unfortunately, I forgot to remove the default from the std::string version of that function. @eddelbuettel also kindly pointed out that I forgot to document the
opparamter which I've also added.TYPE: CPP_API
DESC: Remove default operation type from query condition set membership API