Reduce rtools40 matrix down to the ucrt build used by R since 4.2 #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other two variants are for 32 and 64 bit builds under the preceding setup and no longer needed.
|
This pull request has been linked to Shortcut Story #34286: Reduce CI matrix for MinGW builds down to UCRT build. |
|
@ihnorton opened as discussed, and 'all green' after nudging away one spurious fail. |
ihnorton
approved these changes
Sep 17, 2023
|
Confirmed we are only using ucrt in the R builds on Windows: https://github.com/TileDB-Inc/TileDB-R/blob/3c675c6135d35388df3bab9c804f46956637e3aa/src/Makevars.ucrt#L1 |
eddelbuettel
commented
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other two variants are for 32 and 64 bit builds under the preceding setup and no longer needed.
TYPE: IMPROVEMENT
DESC: Require only ucrt build from Rtools