Support GCS on Windows. #4138
Merged
Support GCS on Windows. #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #3139: Enable GCS support on windows. |
teo-tsirpanis
force-pushed
the
gcs-windows
branch
2 times, most recently
from
a8f0baf to
33e16bb
Compare
Erasing the write cache buffer from the map frees its memory. Before doing it, we move the buffer to a local variable.
ihnorton
reviewed
Oct 17, 2023
|
This PR does not enable GCS on the Windows release binaries. Let me know if you (plural) want to. |
KiterLuc
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-3139
This PR adds support for Google Cloud Storage on Windows. Most things to enable it have already been done, this PR finishes it up by adding a switch on the Windows bootstrap script and a GCS CI leg on Windows CI.
TYPE: FEATURE
DESC: Add support for Google Cloud Storage on Windows