Lums/sc 21342/create specializations for void source sink #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #21342: Create specializations for |
robertbindar
approved these changes
Mar 14, 2023
…nostate as arguments and return values [skip ci]
KiterLuc
force-pushed
the
lums/sc-21342/create-specializations-for-void-source-sink
branch
from
7a3a229 to
e38b23b
Compare
KiterLuc
deleted the
lums/sc-21342/create-specializations-for-void-source-sink
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that dependency-only edges using
std::monostatework with nodes and edges by updating and testing with nodes/test/unit_segmented_nodes.cc. Only changes required were to the testing code.Trying to do dependency-only nodes and edges with
voidfailed because the code tries to take a reference to its arguments, which will work forstd::monostatebut not forvoid.TYPE: IMPROVEMENT
DESC: Verify that dependency-only edges using
std::monostatework with nodes and edges.