Skip to content

Commit

Permalink
Stop setting a default CMAKE_OSX_DEPLOYMENT_TARGET.
Browse files Browse the repository at this point in the history
By moving back to 10.14, some of our test code will not be able to build.
  • Loading branch information
teo-tsirpanis committed Nov 22, 2023
1 parent 33bbb66 commit 101a2a1
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions cmake/Options/BuildOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ option(TILEDB_TESTS_AWS_S3_CONFIG "Use an S3 config appropriate for AWS in tests
option(TILEDB_TESTS_ENABLE_REST "Enables REST tests (requires running REST server)" OFF)

option(CMAKE_EXPORT_COMPILE_COMMANDS "cmake compile commands" ON)
# If -DCMAKE_OSX_DEPLOYMENT_TARGET is passed, it gets added to the cache either way.
# Otherwise, if the environment variable is defined, we let it have effect by not adding
# the option to the cache. If neither is defined, we set a default value.
if(NOT DEFINED ENV{MACOSX_DEPLOYMENT_TARGET})
# By default we target macOS 11 at minimum according to CRAN policy.
# See https://stat.ethz.ch/pipermail/r-package-devel/2023q4/010078.html
option(CMAKE_OSX_DEPLOYMENT_TARGET "macOS minimum target version" 11)
endif()

set(TILEDB_INSTALL_LIBDIR "" CACHE STRING "If non-empty, install TileDB library to this directory instead of CMAKE_INSTALL_LIBDIR.")

Expand Down

0 comments on commit 101a2a1

Please sign in to comment.