Standardize on sentence case #1865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CendioOssman
requested changes
Nov 4, 2024
common/rdr/RandomStream.cxx
Outdated
| @@ -69,7 +69,7 @@ RandomStream::RandomStream() | |||
| { | |||
| #endif | |||
| #endif | |||
| vlog.error("no OS supplied random source - using rand()"); | |||
| vlog.error("No OS supplied random source: Using rand()"); | |||
There was a problem hiding this comment.
A comma suggests an explanation or more details. Perhaps a comma if the dash is undesirable?
There was a problem hiding this comment.
A stray r sneaked in here instead. Otherwise, it looks good. :)
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fixes to both titles as well as for log messages, exceptions and errors.