Handle non-JSON responses from the API #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eated allows us to accept non-json (binary for example) resources sent by the API, like photos or videos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook API endpoints such as
/me/picturereturn things other the JSON. The library made the choice to believe any non-JSON response is an error, which is not the case.I introduced an optional fourth 'reqOptions' parameter for the api/napi method. Currently, there is only one option in there : accepting responses of content-type other than json (see the updated Readme). You can provide a content-type string, an array of content-type strings, or just the string 'any'. I added the
encoding: 'binary'option to the request module to allow pictures, videos and such.