Allow empty claim value to mimic behavior of ASP.NET AuthorizationPolicyBuilder.RequireClaim method

[iam-black]

Ocelot Feature

• Authorization

Proposed Changes

• Allow empty claim value to mimic behavior of ASP.NET RequireClaim(string)
• Refactored the code to remove warnings and messages of compiler in the same file

Docs

• Claims-based authorization in ASP.NET Core | MS Learn
• AuthorizationPolicyBuilder.RequireClaim Method | MS Learn

Relevant topics

• Transform claim key not found to an empty string #1851

[raman-m]

Hi Ihor!
Thanks for your interest in Ocelot!

Is this PR related to some issue in the backlog?

[raman-m]

Ihor,
I know, reviewing of this PR should be pretty easy from my side, but the case is quite specific.
The case should be covered by unit and/or acceptance tests.

${\color{orange}The\ case\ should\ be\ covered\ by\ unit\ and/or\ acceptance\ tests.}$

So, add test(s) please!

Also, I will appreciate if you update and write clear description of user scenario.
After reading of PR title I still cannot get the user scenario... 😞
In what cases the claim value will be empty?

Hope for the soonest reply from you...

[raman-m]

The feature branch has been rebased onto ThreeMammals:develop!
Code review has started...

---

@iam-black Ihor,
Did you create an issue for this?
Or, is the PR related to an existing issue?
Based on the title semantic, I would say that it should be related to standard behavior of ASP.NET pipeline...
Any quick links to MS Learn docs are welcome!

---

I don't see develop branch in your fork! Your fork is too old.

Could you Sync fork please? So, new develop branch will occur with all top commits!

Could you add me as collaborator to your forked repo please? I will create develop branch and make it default.

[raman-m]

Ready for Code Review❕

Given the tests that have passed, I'm evaluating whether this brief continue statement could pose a security risk. 😅
Nevertheless, further testing is necessary...