Skip to content
This repository has been archived by the owner on Dec 26, 2020. It is now read-only.

Commit

Permalink
Rename traits and mojo directory in //ui/base/ime
Browse files Browse the repository at this point in the history
This CL renames mojo to mojom and *_struct_traits.* to
*_mojom_traits.* in //ui/base/ime.

*_struct_traits.* => *_mojom_traits.*
ui/base/ime/mojo => ui/base/ime/mojom

Bug: 806965
Change-Id: Id06c81ffdded6a7cfcdc3602325ef78dc9891b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715479
Commit-Queue: Miyoung Shin <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#681621}
  • Loading branch information
MyidShin authored and Commit Bot committed Jul 27, 2019
1 parent faa0e21 commit b18c476
Show file tree
Hide file tree
Showing 25 changed files with 34 additions and 34 deletions.
2 changes: 1 addition & 1 deletion content/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ mojom("mojo_bindings") {
"//skia/public/interfaces",
"//third_party/blink/public/mojom:mojom_core",
"//third_party/blink/public/mojom:web_feature_mojo_bindings",
"//ui/base/ime/mojo",
"//ui/base/ime/mojom",
"//ui/base/mojom",
"//ui/events/mojom",
"//ui/gfx/geometry/mojom",
Expand Down
2 changes: 1 addition & 1 deletion content/common/input/input_handler.mojom
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import "content/common/native_types.mojom";
import "mojo/public/mojom/base/string16.mojom";
import "mojo/public/mojom/base/time.mojom";
import "third_party/blink/public/mojom/selection_menu/selection_menu_behavior.mojom";
import "ui/base/ime/mojo/ime_types.mojom";
import "ui/base/ime/mojom/ime_types.mojom";
import "ui/events/mojom/event.mojom";
import "ui/events/mojom/event_constants.mojom";
import "ui/gfx/geometry/mojom/geometry.mojom";
Expand Down
2 changes: 1 addition & 1 deletion content/common/render_widget_host_ns_view.mojom
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module remote_cocoa.mojom;
import "content/common/native_types.mojom";
import "content/common/input/input_handler.mojom";
import "mojo/public/mojom/base/string16.mojom";
import "ui/base/ime/mojo/ime_types.mojom";
import "ui/base/ime/mojom/ime_types.mojom";
import "ui/display/mojom/display.mojom";
import "ui/events/mojom/event.mojom";
import "ui/gfx/geometry/mojom/geometry.mojom";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ _typemap_imports = [
"//third_party/blink/public/public_typemaps.gni",
"//ui/accessibility/mojom/typemaps.gni",
"//ui/base/accelerators/mojom/typemaps.gni",
"//ui/base/ime/mojo/typemaps.gni",
"//ui/base/ime/mojom/typemaps.gni",
"//ui/base/mojom/typemaps.gni",
"//ui/display/mojom/typemaps.gni",
"//ui/events/mojom/typemaps.gni",
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/public/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ source_set("blink_headers") {
"//third_party/blink/public/common",
"//ui/accessibility:ax_enums_mojo",
"//ui/base/ime:text_input_types",
"//ui/base/ime/mojo",
"//ui/base/ime/mojom",
"//url",
]

Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/public/mojom/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ mojom("mojom_platform") {
"//services/viz/public/interfaces",
"//skia/public/interfaces",
"//third_party/blink/public/mojom/usb",
"//ui/base/ime/mojo",
"//ui/base/ime/mojom",
"//ui/gfx/geometry/mojom",
"//ui/gfx/mojo",
"//url/mojom:url_mojom_gurl",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
module blink.mojom;

import "mojo/public/mojom/base/string16.mojom";
import "ui/base/ime/mojo/ime_types.mojom";
import "ui/base/ime/mojom/ime_types.mojom";

struct DateTimeSuggestion {
// The date/time value represented as a double.
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/public/web/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ include_rules = [
"+third_party/blink/public/platform",
"+third_party/blink/public/web",
"+ui/accessibility/ax_enums.mojom-shared.h",
"+ui/base/ime/mojo/ime_types.mojom-shared.h",
"+ui/base/ime/mojom/ime_types.mojom-shared.h",

# Allowed only inside INSIDE_BLINK
"+third_party/blink/renderer/core",
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/public/web/web_ime_text_span.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include <vector>

#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/ime/mojo/ime_types.mojom-shared.h"
#include "ui/base/ime/mojom/ime_types.mojom-shared.h"

namespace blink {

Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/renderer/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ source_set("prerequisites") {
"//third_party/ots",
"//third_party/snappy",
"//third_party/zlib",
"//ui/base/ime/mojo",
"//ui/base/ime/mojom",
"//ui/events:dom_keycode_converter",
"//ui/gfx/geometry",
"//ui/native_theme",
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/renderer/core/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ include_rules = [
"+third_party/blink/renderer/core",
"-third_party/blink/renderer/modules",
"+third_party/skia/include",
"+ui/base/ime/mojo/ime_types.mojom-blink.h",
"+ui/base/ime/mojom/ime_types.mojom-blink.h",
"+ui/gfx/geometry",
"+ui/gfx/skia_util.h",
"-web",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
#include "third_party/blink/renderer/platform/wtf/vector.h"
#include "ui/base/ime/mojo/ime_types.mojom-blink.h"
#include "ui/base/ime/mojom/ime_types.mojom-blink.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include "third_party/blink/renderer/core/editing/markers/document_marker.h"
#include "third_party/blink/renderer/platform/wtf/casting.h"
#include "ui/base/ime/mojo/ime_types.mojom-blink.h"
#include "ui/base/ime/mojom/ime_types.mojom-blink.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "third_party/blink/renderer/platform/runtime_enabled_features.h"
#include "third_party/blink/renderer/platform/wtf/functional.h"
#include "third_party/blink/renderer/platform/wtf/text/atomic_string.h"
#include "ui/base/ime/mojo/ime_types.mojom-blink.h"
#include "ui/base/ime/mojom/ime_types.mojom-blink.h"

namespace blink {

Expand Down
4 changes: 2 additions & 2 deletions ui/base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ test("ui_base_unittests") {
"ime/candidate_window_unittest.cc",
"ime/composition_text_unittest.cc",
"ime/input_method_base_unittest.cc",
"ime/mojo/ime_struct_traits_unittest.cc",
"ime/mojom/ime_mojom_traits_unittest.cc",
]
if (is_win) {
sources += [
Expand Down Expand Up @@ -991,7 +991,7 @@ test("ui_base_unittests") {
if (build_ime) {
deps += [
"//ui/base/ime",
"//ui/base/ime/mojo:test_interfaces",
"//ui/base/ime/mojom:test_interfaces",
]
}

Expand Down
2 changes: 1 addition & 1 deletion ui/base/ime/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jumbo_component("ime") {
"//base:i18n",
"//skia",
"//third_party/icu",
"//ui/base/ime/mojo",
"//ui/base/ime/mojom",
"//ui/events",
"//ui/events:dom_keycode_converter",
"//ui/events:events",
Expand Down
6 changes: 3 additions & 3 deletions ui/base/ime/mojo/BUILD.gn → ui/base/ime/mojom/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import("//mojo/public/tools/bindings/mojom.gni")

mojom("mojo") {
mojom("mojom") {
sources = [
"ime_types.mojom",
]
Expand All @@ -16,10 +16,10 @@ mojom("mojo") {

mojom("test_interfaces") {
sources = [
"ime_struct_traits_test.mojom",
"ime_mojom_traits_test.mojom",
]

public_deps = [
":mojo",
":mojom",
]
}
4 changes: 2 additions & 2 deletions ui/base/ime/mojo/OWNERS → ui/base/ime/mojom/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
per-file *_struct_traits*.*=set noparent
per-file *_struct_traits*.*=file://ipc/SECURITY_OWNERS
per-file *_mojom_traits*.*=set noparent
per-file *_mojom_traits*.*=file://ipc/SECURITY_OWNERS

per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

module ui.mojom;

import "ui/base/ime/mojo/ime_types.mojom";
import "ui/base/ime/mojom/ime_types.mojom";

interface IMEStructTraitsTest {
[Sync]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "ui/base/ime/mojo/ime_types_struct_traits.h"
#include "ui/base/ime/mojom/ime_types_mojom_traits.h"

#include <utility>

#include "base/stl_util.h"
#include "base/test/scoped_task_environment.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/ime/mojo/ime_struct_traits_test.mojom.h"
#include "ui/base/ime/mojom/ime_mojom_traits_test.mojom.h"

namespace ui {

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

mojom = "//ui/base/ime/mojo/ime_types.mojom"
mojom = "//ui/base/ime/mojom/ime_types.mojom"
public_headers = [
"//ui/base/ime/ime_text_span.h",
"//ui/base/ime/text_input_type.h",
]
traits_headers = [ "//ui/base/ime/mojo/ime_types_struct_traits.h" ]
traits_headers = [ "//ui/base/ime/mojom/ime_types_mojom_traits.h" ]
sources = [
"//ui/base/ime/mojo/ime_types_struct_traits.cc",
"//ui/base/ime/mojom/ime_types_mojom_traits.cc",
]
public_deps = [
"//ui/base/ime:ime_types",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "ui/base/ime/mojo/ime_types_struct_traits.h"
#include "ui/base/ime/mojom/ime_types_mojom_traits.h"

namespace mojo {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef UI_BASE_IME_MOJO_IME_TYPES_STRUCT_TRAITS_H_
#define UI_BASE_IME_MOJO_IME_TYPES_STRUCT_TRAITS_H_
#ifndef UI_BASE_IME_MOJOM_IME_TYPES_MOJOM_TRAITS_H_
#define UI_BASE_IME_MOJOM_IME_TYPES_MOJOM_TRAITS_H_

#include <vector>

#include "ui/base/ime/ime_text_span.h"
#include "ui/base/ime/mojo/ime_types.mojom.h"
#include "ui/base/ime/mojom/ime_types.mojom.h"
#include "ui/base/ime/text_input_type.h"

namespace mojo {
Expand Down Expand Up @@ -65,4 +65,4 @@ struct EnumTraits<ui::mojom::ImeTextSpanThickness, ui::ImeTextSpan::Thickness> {

} // namespace mojo

#endif // UI_BASE_IME_MOJO_IME_TYPES_STRUCT_TRAITS_H_
#endif // UI_BASE_IME_MOJOM_IME_TYPES_MOJOM_TRAITS_H_
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

typemaps = [ "//ui/base/ime/mojo/ime_types.typemap" ]
typemaps = [ "//ui/base/ime/mojom/ime_types.typemap" ]

0 comments on commit b18c476

Please sign in to comment.