ANSWT refactor #23
Open
ANSWT refactor #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion curve when hitting SAVE button.
…artesian grid in km for tomography rather than degrees.
|
@dylanmikesell thanks a bunch for all this. Haven't had time to check it yet, but will do in the coming days. Will be updated in the coming days, maybe we could chat/video with Aurel ? Cheers |
|
Yes. Video chat would be good. Just fixed the two UTM zone problem in my
fork. Can do a PR but would like to chat with you and Aurelien first to
make sure you like the way I did it.
…On Mon, Oct 26, 2020, 12:08 PM Thomas Lecocq ***@***.***> wrote:
@dylanmikesell <https://github.com/dylanmikesell> thanks a bunch for all
this. Haven't had time to check it yet, but will do in the coming days.
Without having looked at the code, just a remark: be carefull when
converting lat/lon to UTM using pyproj, if a network is across two UTM
zones, we need to fix one, otherwise the distances will be crazy large.
Will be updated in the coming days, maybe we could chat/video with Aurel ?
Cheers
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVIE4UT6F66ZPIB4NRWROLSMW3I7ANCNFSM4S534FHQ>
.
|
…plementation in iFTAN. There is a new parameter in the tomoconfig table. '
|
again, let me know if you feel it's OK and I'll merge :) |
|
Sorry, will get back to you next week. I need to refresh my brain about
this.
…On Wed, May 12, 2021 at 10:28 AM Thomas Lecocq ***@***.***> wrote:
again, let me know if you feel it's OK and I'll merge :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVIE4UGMZV67WOFUOLYQVLTNKUD7ANCNFSM4S534FHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored this code considerably. Many things were moved to functions, including all plot types. Also moved to a grid in kilometers rather than degrees. There is a verbose flag in the code (not accessible from CLI yet) that will turn on logging/debugging output to see the dimensions of various parameters/matrices. There is also a plot flag for either UTM or local. Local shows plots in a local grid relative to mean station location. This is not a CLI input yet either. Have to change source code. I took all of the UTM conversion from https://gist.github.com/twpayne/4409500. I include the "unproject()" function so we can go back to lat/lon for plotting. But this is not currently implemented.