Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add position nudgestack #1

Open
wants to merge 131 commits into
base: master
Choose a base branch
from
Open

Add position nudgestack #1

wants to merge 131 commits into from

Conversation

ThomasKnecht
Copy link
Owner

I added an new example of a timeline. I think the position_nudgestack is best used with timeseries.

@ThomasKnecht ThomasKnecht requested a review from krlmlr September 16, 2019 12:07
@krlmlr
Copy link
Collaborator

krlmlr commented Sep 18, 2019

The .svg file looks odd when rendered: https://github.com/TeddyLeeJones/ggplot2/blob/d5c58da560999c63e499081c83fe4e776f6f48d2/tests/figs/position-nudgestack/nudgestack-eustockmarkets-data.svg

@ThomasKnecht
Copy link
Owner Author

ThomasKnecht commented Sep 18, 2019 •
edited
Loading

All figures in fig look the same on GitHub e.g:
In my fork:
https://github.com/TeddyLeeJones/ggplot2/blob/d5c58da560999c63e499081c83fe4e776f6f48d2/tests/figs/geom-violin/basic.svg

In original:
https://github.com/tidyverse/ggplot2/blob/master/tests/figs/geom-violin/basic.svg

Thomas Knecht and others added 29 commits October 7, 2019 12:01
@ThomasKnecht
Delete packages from @examples
5270a9d
@ThomasKnecht
Add new examples
fbf28dc
@ThomasKnecht
Add test file with a doppelganger-test
3ba06ab
@ThomasKnecht
Add validated svg for position_nudgestack
f26bb90
@ThomasKnecht
Add tests for correct nudging and stacking
3a1c71f
@ThomasKnecht
Add time series example
71d567b
@ThomasKnecht
Add position-nudgestack.R into man
59bc2a0
@ThomasKnecht
Bugfix
28640d5
@ThomasKnecht
Use tsbox for converting ts object to tibble
8848fd9
@ThomasKnecht
Adjust filter criterion in examples
e5d61b5
@ThomasKnecht
Add new examples
65e72fb
@ThomasKnecht
Add test file with a doppelganger-test
1b61750
@ThomasKnecht
Add tests for correct nudging and stacking
4d66dad
@ThomasKnecht
Resolve conflict
e4e7ee0
@ThomasKnecht
Use tsbox for converting ts object to tibble
369a34b
@ThomasKnecht
Style file
b61211d
@ThomasKnecht
Style file
6e4398c
@ThomasKnecht
Add news
415811c
@ThomasKnecht
Add time series example
90d1257
@ThomasKnecht
Add test file with a doppelganger-test
598b786
@ThomasKnecht
Add validated svg for position_nudgestack
662a5da
@ThomasKnecht
Add tests for correct nudging and stacking
739ac7c
@ThomasKnecht
Add the zoo-package to Suggestions
3210061
@ThomasKnecht
Add new examples
325456a
@ThomasKnecht
Resolve conflict
e0368b0
@ThomasKnecht
Style file
d9ec752
@ThomasKnecht
Add package spezifications
5de0449
@ThomasKnecht
Add package spezifications
e1846bc
@ThomasKnecht
Resolve conflict
b049018 
Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

# Conflicts:
#	R/position-nudgestack.R
@ThomasKnecht
Copy link
Owner Author

ThomasKnecht commented Oct 7, 2019 •
edited
Loading

@krlmlr Can you do the rebase for me. There are still problems and the git history looks weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ThomasKnecht @krlmlr @MaraAlexeev @paleolimbot @bfgray3 @thomasp85 @mine-cetinkaya-rundel