Set gIsDebugBattle to FALSE after battle #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello, I was trying your debug menu and its new features since the last time I had pulled from it, which has been very useful in development. I was using the battle test option to create a wild battle with a Bulbasaur, but then I noticed some buggy behaviour where all other trainer battles would be against the same Bulbasaur and terrain. I believe this is because gIsDebugBattle is never set to FALSE after starting the debug battle which causes all other battles to load the saved party, so I tried adding a check in battle_setup.c to set it to FALSE in the callback after the battle ends if that is fine.
Discord contact info
Flame#9168