Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Analyze commits in batches of 2000 #86

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: Analyze commits in batches of 2000 #86

merged 1 commit into from
Nov 8, 2023

Conversation

eemelipa
Copy link
Contributor

@eemelipa eemelipa commented Nov 6, 2023

Fixes #85

@eemelipa
Copy link
Contributor Author

eemelipa commented Nov 6, 2023

This fixed the issue for me locally. Having the batch size 2000 shouldn't affect too negatively the performance. It could be made configurable in the future if needed. I didn't yet get to the point of testing it in CI

Not sure if there's any sensible way of unit-testing this change

@TheUnderScorer
Copy link
Owner

This is interesting 😁. Thanks @eemelipa!

@TheUnderScorer TheUnderScorer merged commit a028765 into TheUnderScorer:master Nov 8, 2023
4 checks passed
TheUnderScorer pushed a commit that referenced this pull request Nov 8, 2023
@semantic-release-bot
chore(release): nx-semantic-release-v2.7.1 [skip ci]
a95a35e 
## [2.7.1](nx-semantic-release-v2.7.0...nx-semantic-release-v2.7.1) (2023-11-08)

### Bug Fixes

* Analyze commits in batches of 2000 ([#86](#86)) ([a028765](a028765))
* Update package-lock dependencies ([#87](#87)) ([1a03363](1a03363))
@TheUnderScorer
Copy link
Owner

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheUnderScorer TheUnderScorer Awaiting requested review from TheUnderScorer TheUnderScorer is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analyzeCommits fails to Error: spawn EBADF
2 participants
@eemelipa @TheUnderScorer