-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade deps with npm vulnerability #106
Conversation
db0bc22
to
a2b50ba
Compare
a2b50ba
to
e2711bf
Compare
@TheUnderScorer I don't know if you want to keep Node v18 support or not, I chose a less aggressive upgrade. However, if you are willing to drop support for v18, there is a newer version of both libraries: |
Thanks for the PR @Balvajs. Pls rebase on the BTW. I'm not sure if this change won't break the plugin, since the |
As I expected 😔. I will try to experiment with some workarounds, because It would be good to update semantic-release to latest version as well, but it will take some time. |
@TheUnderScorer I will try to make it work, I am using pure ESM dependencies in executors in our company's NX monorepo and it works. It's using dynamic import syntax that's not nice, but it gets the job done and we can keep using the latest package versions: const execa = await (new Function('return import("execa")')() as Promise<
typeof import('execa')
>); |
@TheUnderScorer @Balvajs Could this merge please be fixed and take place? |
@corwestermaniddink I wasn't able to make it work 😕 And we switched to https://github.com/jscutlery/semver, so I won't be digging into this anymore and close the PR. |
Please be-aware that you use "semantic-release" npm pkg in your package.json, they use an old version of "semver" npm pkg with this vulnerability: GHSA-c2qf-rxjj-qqgw in their latest version. "semantic-release" didn't update for 4 years "semver" in their package.json! |
The
@semantic-release/npm
dependency reports vulnerability because it's dependent onnpm
.With https://github.com/semantic-release/npm/releases/tag/v11.0.3 the vulnerability was removed, and it's also the last version before dropping support for Node v18.
Together with the upgrade of
@semantic-release/npm
the https://github.com/semantic-release/github/releases/tag/v9.2.6 can be safely upgraded because it's last version before dropping support for Node v18.Closes #99
BREAKING CHANGE:
Drop support for Node v16 and v19. Supported Node versions are now
^18.17
or>=20
.