fix: release to npm after user defined plugins #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `@semantic-release/npm` being used before `@semantic-release/git` the NPM release doesn't contain updated `CHANGELOG.md` and `package.json`. And that can be very confusing for the consumers of the package. Simply changing the order of plugins should fix that. GitHub plugin already is in that order, so it will be consistent.
Balvajs
changed the title
Balvajs
changed the title
Balvajs
changed the title
Balvajs
changed the title
TheUnderScorer
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [2.11.0](nx-semantic-release-v2.10.0...nx-semantic-release-v2.11.0) (2024-04-10) ### Features * release to npm after user defined plugins ([#105](#105)) ([a573495](a573495))
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
@semantic-release/npmis used, updatedCHANGELOG.mdis not in the new version release. It's caused bynx buildrunning beforesemantic-releaseplugins, and thedist/{project}/CHANGELOG.mddon't get updated.This could be fixed by users of
nx-semantic-releaseby setting.nxreleaserc.json:{ "plugins": [ [ "@semantic-release/changelog", { "changelogFile": "${WORKSPACE_DIR}/dist/${RELATIVE_PROJECT_DIR}/CHANGELOG.md" } ] ] }However, because the
@semantic-release/npmruns before user-defined plugins, it's not possible.So this PR changes that order of
@semantic-release/npmand it's putting it before@semantic-release/gittogether with@semantic-release/github, which seems a more consistent setup anyway.@semantic-release/npmhas to stay before@semantic-release/git, because otherwise the changes topackage.jsonaren't committed.I am not sure how to do it, but some solution that wouldn't require users to define additional
@semantic-release/changelogin the config would be definitely nicer.