Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify git config option #103

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rkclark
Copy link
Contributor

@rkclark rkclark commented Mar 4, 2024

Hi, thanks for the great library.

Here's a suggested readme update which I think makes the "git" config option clearer. The @semantic-release/git plugin doesn't do anything with git tags - that is handled by semantic release itself.

Because of the mention of tags, I didn't realise that the git option was turning the @semantic-release/git plugin on or off - I was searching for a way to do this for quite a while until I realised it after reading a closed issue on this repo.

Hope this helps.

Cheers

@rkclark rkclark requested a review from TheUnderScorer as a code owner March 4, 2024 10:48
Copy link
Owner

@TheUnderScorer TheUnderScorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rkclark !

@TheUnderScorer TheUnderScorer merged commit 824e75f into TheUnderScorer:master Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants