Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relay parameters field numbers #6778

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

This PR fixes the field numbers for the relay modes in the RelayParameters message.

Changes

  • Fix the field numbers in the RelayParameters message.

Testing

N/A.

Regressions

Existing end devices will have to rejoin - this is an acceptable tradeoff at this stage in development. We won't be able to change this later on after we officially release the CLI and the documentation.

Notes for Reviewers

No need to review.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.29.0 milestone Dec 18, 2023
@adriansmares adriansmares self-assigned this Dec 18, 2023
@adriansmares adriansmares marked this pull request as ready for review December 18, 2023 20:00
@adriansmares adriansmares requested a review from a team as a code owner December 18, 2023 20:00
@adriansmares adriansmares merged commit 8d030aa into v3.29 Dec 18, 2023
14 checks passed
@adriansmares adriansmares deleted the fix/relay-field-numbers-2 branch December 18, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant