Merge pull request #6640 from TheThingsNetwork/fix/uplink-simulation

Add transmission settings set flags generation
TheThingsNetwork · Oct 20, 2023 · 6054f3c · 6054f3c
2 parents 94a1cda + c2f8168
commit 6054f3c
Show file tree

Hide file tree

Showing 7 changed files with 308 additions and 18 deletions.
diff --git a/api/ttn/lorawan/v3/identifiers.proto b/api/ttn/lorawan/v3/identifiers.proto
@@ -228,7 +228,7 @@ message EndDeviceVersionIdentifiers {
 message NetworkIdentifiers {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   // LoRa Alliance NetID.
   bytes net_id = 1 [

diff --git a/api/ttn/lorawan/v3/lorawan.proto b/api/ttn/lorawan/v3/lorawan.proto
@@ -530,7 +530,7 @@ enum TxSchedulePriority {
 message LoRaDataRate {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   // Bandwidth (Hz).
   uint32 bandwidth = 1;
@@ -541,7 +541,7 @@ message LoRaDataRate {
 message FSKDataRate {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   // Bit rate (bps).
   uint32 bit_rate = 1;
@@ -550,7 +550,7 @@ message FSKDataRate {
 message LRFHSSDataRate {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   uint32 modulation_type = 1;
   // Operating Channel Width (Hz).
@@ -561,7 +561,7 @@ message LRFHSSDataRate {
 message DataRate {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   oneof modulation {
     option (validate.required) = true;
@@ -578,13 +578,13 @@ message DataRate {
 message TxSettings {
   option (thethings.flags.message) = {
     select: true,
-    set: false
+    set: true
   };
   // Transmission settings for downlink.
   message Downlink {
     option (thethings.flags.message) = {
       select: true,
-      set: false
+      set: true
     };
     // Index of the antenna on which the uplink was received and/or downlink must be sent.
     uint32 antenna_index = 1;

diff --git a/pkg/ttnpb/identifiers.pb.go b/pkg/ttnpb/identifiers.pb.go
diff --git a/pkg/ttnpb/identifiers_flags.pb.go b/pkg/ttnpb/identifiers_flags.pb.go
diff --git a/pkg/ttnpb/lorawan.pb.go b/pkg/ttnpb/lorawan.pb.go