Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace React badges with new versions #4163

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Sep 20, 2023

Because

  • The current ones use the wrong color

This PR

  • Replaces them with new amazing versions by @ManonLef

Issue

Closes: #4088

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section

@ManonLef ManonLef added create-review-app Create a Heroku review app for pull request and removed create-review-app Create a Heroku review app for pull request labels Sep 20, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4163 September 20, 2023 21:18 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4163 September 22, 2023 19:59 Inactive
@KevinMulhern
Copy link
Member

Thanks for doing this @Asartea, theres a bit of a bug with the borderless badge. I'm not 100% whats causing the problem is.
Screenshot 2023-09-22 at 21 10 05

But.. this amended version of the full badge seems to work ok for the borderless badge:
badge-react-borderless

@Asartea
Copy link
Contributor Author

Asartea commented Sep 23, 2023

Weird; have pushed the new image

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4163 September 23, 2023 09:42 Inactive
@KevinMulhern
Copy link
Member

Something weird is going on @Asartea, the borderless badge is missing

@KevinMulhern
Copy link
Member

Need any help with this @Asartea?

@Asartea
Copy link
Contributor Author

Asartea commented Oct 7, 2023

I'm going to be honest: I thought I pushed something for this and then completely forgot about it. Will try and get a working file up today

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4163 October 18, 2023 13:33 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - thanks @Asartea

@KevinMulhern KevinMulhern merged commit 321bd66 into TheOdinProject:main Oct 18, 2023
@Asartea Asartea deleted the fix/fix-react-logo-color branch October 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-review-app Create a Heroku review app for pull request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect color pattern for react badge on React Lesson
3 participants