Feature: Optimize theme switcher performance #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
force-pushed
the
feature/speed-up-theme-switching
branch
from
6c1d135 to
e0541e0
Compare
KevinMulhern
added
the
Type: Enhancement
3 tasks
CouchofTomato
approved these changes
Sep 11, 2023
|
My bad on the merge conflict mate. |
Because: * There is a noticeable delay between switching the theme and the theme icon updating This commit: * Toggles the theme class in the same turbo stream request we use to update the theme icon. * Adds a custom turbo stream action to toggle classes on elements
KevinMulhern
force-pushed
the
feature/speed-up-theme-switching
branch
from
e0541e0 to
ffe7a8e
Compare
|
No worries @CouchofTomato, easy enough sorted. Thanks for the review mate 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Before:
https://github.com/TheOdinProject/theodinproject/assets/7963776/6870d2a3-27af-413a-9df8-3adca85d6c4d
After:
https://github.com/TheOdinProject/theodinproject/assets/7963776/28cbb153-2348-4976-b11a-8245d85143fd