Fix: Creating flags on review apps attempting to notify our flags Discord channel #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cord channel Because: * When creating a flag on a review app it was returning a 500 response because the discord notifier isn't configured. * We don't want testing flags on review apps to create noise in our Discord channel. This commit: * Do not run the discord notifier service if we're in the development environment or staging (review apps). * Removes the json responses for creating flags, those were used from the removed react implementation of the flag form.
KevinMulhern
force-pushed
the
fix/flags-discord-notifications-from-review-apps
branch
from
6af5c5d to
d7ffaf1
Compare
KevinMulhern
added
the
Type: Bug
CouchofTomato
approved these changes
Sep 3, 2023
KevinMulhern
deleted the
fix/flags-discord-notifications-from-review-apps
branch
ZachBaird
pushed a commit
to ZachBaird/theodinproject
that referenced
this pull request
Sep 4, 2023
…cord channel (TheOdinProject#4107) Because: * When creating a flag on a review app it was returning a 500 response because the discord notifier isn't configured. * We don't want testing flags on review apps to create noise in our Discord channel. This commit: * Do not run the discord notifier service if we're in the development environment or staging (review apps). * Removes the json responses for creating flags, those were used from the removed react implementation of the flag form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: