Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby-version and gemfile to use 3.1.2 #4

Merged

Conversation

scheals
Copy link
Contributor

@scheals scheals commented May 26, 2022

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Data types exercise: Update spec files

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have ensured any exercise files included in this PR have passed all of their tests

1. Because:

The Ruby version curriculum is moving towards is 3.1.2 due the fact that only Ruby 3.1+ supports openSSL 3 and previous versions do not - making using 3.0.3 on Ubuntu 22.04 and such impossible without using workarounds including reverting to openSSL 1.1.

Part of TheOdinProject/curriculum#24112

2. This PR:

  • Updates bundler to version shipped with 3.1.2
  • Updates gems and ruby-version through bundle update
  • Previous point created a ruby-version file because it was previously missing

3. Additional Information:

@scheals
Copy link
Contributor Author

scheals commented Jun 7, 2022

I have gone through someone's completed repo and made sure every tests pass without any issues.

Copy link
Member

@ChargrilledChook ChargrilledChook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, I think the .ruby-version files are slightly overkill for the exercise repos, but not a blocker for me. It is more consistent this way

@scheals
Copy link
Contributor Author

scheals commented Jun 9, 2022

Side note, I think the .ruby-version files are slightly overkill for the exercise repos, but not a blocker for me. It is more consistent this way

Yeah it's for consistency's sake and nothing else at least from my POV.

@ChargrilledChook ChargrilledChook merged commit 2bda2f9 into TheOdinProject:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants