Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assignment link in DOM_manipulation_and_events.md #29144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scuddi
Copy link

@scuddi scuddi commented Dec 1, 2024

Because

Old link linked to the second active learning at MDN, new link links to the first active learning which gives the foundation for the second exercise.

I had problems starting with the second exercise, doing the first before helped me a lot and made the second a lot easier.

If this was intended and the link stays the same I would recommend to write at least a hint to the first active learning or state specifically to start with the shopping list.

This PR

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Changed the link/anchor under ### Assignment which links to MDNs Active Learning section on DOM manipulation.

Old link/anchor: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Client-side_web_APIs/Manipulating_documents#active_learning_a_dynamic_shopping_list

New link/anchor: #active_learning_basic_dom_manipulation

Old link linked to the second active learning at MDN, new link links to the first active learning which gives the foundation for the second exercise.

I had problems starting with the second exercise, doing the first before helped me a lot and made the second a lot easier.

If this was intended and the link stays the same I would recommend to write at least a hint to the first active learning or state specifically to start with the shopping list.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant