Ruby: Project: Caesar Cipher: Fix Ruby Caesar Cipher code example #29107
Conversation
A left shift of 5 for the string "What a string" should yield the value "Rcvo v nomdib!". The output in the example shows a right shift of 5. At the very least, the example from Wikipedia shows a left shift of three, "D->A" and "E->B" while the code example shows a right shift. The examples should be consistent on the page.
There was a problem hiding this comment.
@JeffreyMPrice Hello and thanks for making a PR to our curriculum.
In the future, please wait to be assigned an issue by a maintainer before beginning work on it. This allows us to discuss the problem, and it helps prevent situations where multiple people work on the same issue.
For this PR, I think the change you've made here is actually more confusing. The CS50 video uses a right shift, and every solution submitted by learners is also going to use a right shift.
I would accept a little note after the Wikipedia quote to specify that the project should use a right shift, but I think requiring the project to use a left shift isn't a good idea.
* Add to project instructions using a right shift * Add to quick tips that Wikipedia shows a left shift * Fix lower case ceaser
|
Thanks @JoshDevHub ! I'll wait for the assignment next time. I've reverted the change in output and updated the instructions to explicitly call for a right shift. I added to the quick tips that Wikipedia shows a left shift. Also threw in fixing a lower case Caesar. You are right about all the submitted solutions! I didn't think about that. |
Because
There is an internal inconsistency on whether a caesar cipher should use a left shift or right shift. In the entry from Wikipedia the text and example used a left shift, while in the ruby code a right shift is used.
This PR
Update the project instructions to explicitly call for a right shift and note that the Wikipedia quote uses a left shift.
Issue
Closes #29106
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection