Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solvingincosistentlink #29085

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Rajaravi99
Copy link
Contributor

Because

In the Project: homepage section both the tablet and mobile design files open in a new tab while the desktop file is downloaded. This PR is raised to solve this issue.

This PR

This PR will help create similarity between how links open on a webpage, clicking on each link will open a new tab.

Issue

This PR is the 2nd out of total 2 PRs, Closes #28796.

Additional Information

This PR is created after adding the statically generated link to the required curriculum content, following the proper naming convention as given in the reference.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Nov 14, 2024
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @Rajaravi99

@KevinMulhern KevinMulhern merged commit 30c9dd7 into TheOdinProject:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Advanced HTML and CSS>: <Inconsistent link leads to download instead of opening in browser>
2 participants