React : Fixed overview #29047
Merged
React : Fixed overview #29047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoShizhong
suggested changes
Nov 3, 2024
There was a problem hiding this comment.
Just some linting and small word fixes for grammar/flow, but otherwise thank you for sorting these out.
After you've made the changes below, could you also run the fix:lesson script on the "Introduction to React" file please? That should fix the remaining lint errors there.
| @@ -6,8 +6,8 @@ In this lesson, we will cover keys in React. Keys are special props for our comp | |||
|
|
|||
| This section contains a general overview of topics that you will learn in this lesson. | |||
|
|
|||
| - What are keys and why does React need them? | |||
| - What are good and bad examples of keys? | |||
| - Learn what are keys and their need in React. | |||
There was a problem hiding this comment.
Suggested change
| - Learn what are keys and their need in React. | |
| - Learn what keys are in React and why it needs them. |
Comment on lines
9
to
11
| - Learn about Reach components. | ||
| - Understand how to create Components. | ||
| - Find where do components reside in a React project. |
There was a problem hiding this comment.
Suggested change
| - Learn about Reach components. | |
| - Understand how to create Components. | |
| - Find where do components reside in a React project. | |
| - Learn about React components. | |
| - Understand how to create components. | |
| - Describe where components reside in a React project. |
| @@ -8,7 +8,7 @@ This section contains a general overview of topics that you will learn in this l | |||
|
|
|||
| - Understand what React is | |||
There was a problem hiding this comment.
Suggested change
| - Understand what React is | |
| - Understand what React is. |
| @@ -8,7 +8,7 @@ This section contains a general overview of topics that you will learn in this l | |||
|
|
|||
| - Understand what React is | |||
|
|
|||
| ### What is React? | |||
| ### Get familiar with React and its key features. | |||
There was a problem hiding this comment.
This heading doesn't need changing, only the lesson overview item as above.
Suggested change
| ### Get familiar with React and its key features. | |
| ### What is React? |
| - Explore how to create nested and dynamic paths in React Router. | ||
| - Discover how to add a 'catch-all' route in React Router. | ||
| - Learn how to pass data from a parent component to any child components rendered via an outlet. | ||
| - Understand how to implement protected routes in React Router. |
There was a problem hiding this comment.
Suggested change
| - Understand how to implement protected routes in React Router. | |
| - Understand how to implement protected routes in React Router. | |
There was a problem hiding this comment.
What's the correction here ? They both look the sasme 😓
There was a problem hiding this comment.
There's a blank line after the list you accidentally removed.
MaoShizhong
suggested changes
Nov 4, 2024
| - Where do components live? | ||
| - Learn about React components. | ||
| - Understand how to create components. | ||
| - Describe where components reside in a React projects. |
There was a problem hiding this comment.
Suggested change
| - Describe where components reside in a React projects. | |
| - Describe where components reside in a React project. |
MaoShizhong
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Some overview points didn't abide the rules , this fixed them .
This PR
Issue
Closes #29039
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection