Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router: Clarify instructions for accessing sub-pages #29038

Merged

Conversation

mhamza-khalid
Copy link
Contributor

@mhamza-khalid mhamza-khalid commented Nov 2, 2024

Because

This PR clarifies the instructions for navigating to specific profile pages (/profile/popeye and /profile/spinach) by manually entering the path in the URL. It aims to reduce confusion for users who may expect links or a navbar to access the children routes.

This PR

  • Updated the lesson instructions in the .md file to clarify that users can access `/profile/popeye `and `/profile/spinach` by appending `/popeye` or `/spinach `to the `/profile` URL.

Issue

Closes #29031

Additional Information

No additional information.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Nov 2, 2024
@mhamza-khalid mhamza-khalid changed the title Clarify instructions for accessing /profile/popeye and /profile/spina… React Router: Clarify instructions for accessing sub-pages Nov 2, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the lint errors - they're out of scope for this PR.

@MaoShizhong MaoShizhong merged commit a289ecf into TheOdinProject:main Nov 2, 2024
2 of 3 checks passed
@mhamza-khalid mhamza-khalid deleted the improve-instructions branch November 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Router: Links missing in code
2 participants