Tic-tac-toe: Explicit the game's independence from user input #29028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softy-dev
force-pushed
the
patch-2
branch
2 times, most recently
from
f85d1d3
to
f7f2de0
Compare
MaoShizhong
reviewed
Oct 30, 2024
| 1. In this project, think carefully about where each bit of logic should reside. Each little piece of functionality should be able to fit in the game, player or gameboard objects. Take care to put them in “logical” places. Spending a little time brainstorming here can make your life much easier later! | ||
| 1. If you’re having trouble, [Building a house from the inside out](https://www.ayweb.dev/blog/building-a-house-from-the-inside-out) is a great article that lays out a highly applicable example both of how you might approach tackling this project as well as how you might organize and structure your code. | ||
| 1. Focus on getting a working game in the console first. Make sure you include logic that checks for when the game is over! You should be checking for all winning 3-in-a-rows and ties. Try to avoid thinking about the DOM and your HTML/CSS until your game is working. Don't worry about taking user input at this point either: you can pass arguments to your functions and play the game yourself to check if everything is working as intended. |
There was a problem hiding this comment.
Punctuation nit + wording suggestion. A sensible addition, this clarification!
Suggested change
| 1. Focus on getting a working game in the console first. Make sure you include logic that checks for when the game is over! You should be checking for all winning 3-in-a-rows and ties. Try to avoid thinking about the DOM and your HTML/CSS until your game is working. Don't worry about taking user input at this point either: you can pass arguments to your functions and play the game yourself to check if everything is working as intended. | |
| 1. Focus on getting a working game in the console first. Make sure you include logic that checks for when the game is over! You should be checking for all winning 3-in-a-rows and ties. Try to avoid thinking about the DOM and your HTML/CSS until your game is working. Don't worry about taking user input at this point either. You can call your functions and pass arguments to them to play the game yourself and check if everything is working as intended. |
MaoShizhong
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Because they imagine a person playing tic-tac-toe, students usually think that they require something to take their input (prompt) for the game to work (like they did in RPS), which isn't true. I think a reminder that this isn't needed at all would be useful so that they don't have to refactor the code when they reach the DOM stage because they introduced an unneeded step earlier.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection