-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comments for custom rules as requested by reviewer #29018
Conversation
Carryover from #29012 You don't need to open new PRs for every change requested. PRs just track a branch so you only need to commit and push any changes to your Since you've opened this PR already I'll use this one and close the old one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the indentation of the new comments please? They're both indented by 2 spaces too many.
You don't need to make a new PR, just push the changes to this branch.
Thank you for your feedback! I’ll go ahead and fix the indentation of the comments as requested. Once I’ve made the changes, I’ll push the updates to this branch. |
.markdownlint-cli2.jsonc
Outdated
}, | ||
// Custom rules specific to the project | ||
// Docs for each rule can be found in `./markdownlint/docs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that the comments were indented too much, not that the closing brace wasn't indented enough.
}, | |
// Custom rules specific to the project | |
// Docs for each rule can be found in `./markdownlint/docs` | |
}, | |
// Custom rules specific to the project | |
// Docs for each rule can be found in `./markdownlint/docs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now updated the comments in the .markdownlint-cli2.jsonc
file as requested. Just to clarify, my previous comments were aligned with the formatting of the other comments in the file, correct? Please let me know if there’s anything else that needs adjustment. Thank you!
Co-authored-by: MaoShizhong <[email protected]>
Because
This PR
Issue
Related to #29012
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section