Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "scheme" term over "protocol" in links-and-images.md #28979

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

martineau-sw
Copy link
Contributor

Opt to use scheme over protocol in Links and Images course to infer broader use cases of absolute links based on reading found in "How Does the Web Work?" course. Specific article is a prerequisite reading of DNS reading and directly linked as a refresher.

Because

Prefer the term "scheme" over "protocol" based on What is a URL? MDN article and Introduction to HTTP book within How Does the Web Work? to infer broader use cases of absolute links to new web developers.

This PR

  • Change "protocol" occurrences to "scheme" within the lesson
  • Inline link to MDN article about structure of URL as a refresher and more information

Additional Information

Root Discord message of reply thread between marti (myself) and Mao && "Don't rush learning!"

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Opt to use scheme over protocol to infer broader use cases of absolute links based on reading found in "How Does the Web Work?" course. Specific article is a prerequisite reading of DNS reading and directly linked as a refresher.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 20, 2024
Update MSN article link with section header

Co-authored-by: MaoShizhong <[email protected]>
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@MaoShizhong MaoShizhong merged commit 1014b69 into TheOdinProject:main Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants