-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack: Make bash formatting in install statements consistent #28948
Conversation
We need to install and tell Webpack to use something called `html-loader`, which will detect image file paths in our HTML template and load the right image files for us. Without this, `./odin.png` would just be a bit of text that will no longer reference the correct file once we run Webpack to build into `dist`. Let's install it: | ||
|
||
```bash | ||
npm install --save-dev html-loader | ||
``` | ||
|
||
then add the following object to the `modules.rules` array within `webpack.config.js`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to install and tell Webpack to use something called `html-loader`, which will detect image file paths in our HTML template and load the right image files for us. Without this, `./odin.png` would just be a bit of text that will no longer reference the correct file once we run Webpack to build into `dist`. Let's install it: | |
```bash | |
npm install --save-dev html-loader | |
``` | |
then add the following object to the `modules.rules` array within `webpack.config.js`: | |
We need to install and tell Webpack to use something called `html-loader`, which will detect image file paths in our HTML template and load the right image files for us. Without this, `./odin.png` would just be a bit of text that will no longer reference the correct file once we run Webpack to build into `dist`. Let's install it: | |
```bash | |
npm install --save-dev html-loader | |
``` | |
Then, add the following object to the `modules.rules` array within `webpack.config.js`: |
A fair improvement made. Just a nit that needs changing as above to make sure things are aligned properly and the list numbering doesn't get broken up (as per the screenshot below):
There are a lot of extra unwanted changes that look like it came from a formatter on your local device. Could these changes be reverted please? We only need the changes requested up above. |
There you go! Are the changes satisfactory? |
Just need to remove the spaces from those "blank" lines so that they're actually blank lines, then we should be good to go! |
Woops, my bad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Because
In the whole article, all commands detailing the installing of a package are written with a bash formatting, except for the edited one. When skimming through the page, one can end up skipping the command instruction this way.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section