-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 Classes: General language/structure touch-up #28947
Open
MaoShizhong
wants to merge
8
commits into
TheOdinProject:main
Choose a base branch
from
MaoShizhong:es6-classes-touchup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+21
−28
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c92fe45 - Browse repository at this point
Copy the full SHA c92fe45View commit details -
At this point in time, the good/bad controversies aren't so prevalent given it's now been 9 years since ES6 release. Many of the resources around criticising or analysing pros/cons of class syntax appear to be within a year or two of ES6 release, and before additional features were added, like private properties. This content has led to several doubts about whether it's worth learning class syntax and whether it's "bad and shouldn't be used", despite it now being somewhat commonplace.
Configuration menu - View commit details
-
Copy full SHA for 550b54a - Browse repository at this point
Copy the full SHA 550b54aView commit details -
Refresh structure and verbiage of assignments
Removed mixins - common pain point as it goes a lot deeper than necessary at this point
Configuration menu - View commit details
-
Copy full SHA for 9b29088 - Browse repository at this point
Copy the full SHA 9b29088View commit details -
Move composition/inheritance to OOP Principles lesson
More relevant topics in that lesson as opposed to class syntax.
Configuration menu - View commit details
-
Copy full SHA for 182a62b - Browse repository at this point
Copy the full SHA 182a62bView commit details -
Reorganise lesson overview and knowledge checks
To match assignment structure
Configuration menu - View commit details
-
Copy full SHA for d50899a - Browse repository at this point
Copy the full SHA d50899aView commit details -
Less focus on "using classes might not be good" and more focus on how the underlying mechanics are still the same prototypal inheritance with different syntax.
Configuration menu - View commit details
-
Copy full SHA for ea68db2 - Browse repository at this point
Copy the full SHA ea68db2View commit details
Commits on Nov 7, 2024
-
Add note about section in assigned article
Section goes out of scope for this TOP lesson.
Configuration menu - View commit details
-
Copy full SHA for eb415d8 - Browse repository at this point
Copy the full SHA eb415d8View commit details
Commits on Nov 28, 2024
-
Original wording could be misinterpreted to mean that Player.prototype actually is the same object as Person.prototype, instead of inheriting from it.
Configuration menu - View commit details
-
Copy full SHA for 5b5c566 - Browse repository at this point
Copy the full SHA 5b5c566View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.