Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 Classes: General language/structure touch-up #28947

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 12, 2024

  1. Update intro verbiage

    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c92fe45 View commit details
    Browse the repository at this point in the history
  2. Remove pros/cons content

    At this point in time, the good/bad controversies aren't so prevalent
    given it's now been 9 years since ES6 release.
    Many of the resources around criticising or analysing pros/cons of class
    syntax appear to be within a year or two of ES6 release, and before
    additional features were added, like private properties.
    This content has led to several doubts about whether it's worth learning
    class syntax and whether it's "bad and shouldn't be used", despite it
    now being somewhat commonplace.
    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    550b54a View commit details
    Browse the repository at this point in the history
  3. Refresh structure and verbiage of assignments

    Removed mixins - common pain point as it goes a lot deeper than necessary at this point
    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    9b29088 View commit details
    Browse the repository at this point in the history
  4. Move composition/inheritance to OOP Principles lesson

    More relevant topics in that lesson as opposed to class syntax.
    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    182a62b View commit details
    Browse the repository at this point in the history
  5. Reorganise lesson overview and knowledge checks

    To match assignment structure
    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    d50899a View commit details
    Browse the repository at this point in the history
  6. Reverse "controversy" content

    Less focus on "using classes might not be good" and more focus on how the
    underlying mechanics are still the same prototypal inheritance with different
    syntax.
    MaoShizhong committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    ea68db2 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add note about section in assigned article

    Section goes out of scope for this TOP lesson.
    MaoShizhong committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    eb415d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Rephrase "extend" verbiage

    Original wording could be misinterpreted to mean that Player.prototype
    actually is the same object as Person.prototype, instead of inheriting
    from it.
    MaoShizhong committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5b5c566 View commit details
    Browse the repository at this point in the history