Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to pseudo-selectors in advanced_selectors.md #28880

Closed
wants to merge 1 commit into from

Conversation

abeeto
Copy link

@abeeto abeeto commented Sep 30, 2024

Because

Changes the previous broken links to pseudo selectors from css-tricks.com to new links in line with their restructured almanac page.

This PR

Issue

Closes #XXXXX

Additional Information

PS: My first commit/PR to TOP, great work everyone!

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Changes the previous broken links to pseudo selectors from css-tricks.com to new links in line with their restructured almanac page.

PS: My first commit to TOP, great work everyone!
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Sep 30, 2024
@MaoShizhong
Copy link
Contributor

Thanks for the PR @abeeto. Looks like this would close #28876 but that's already been assigned to the issue author. As per our contributing guide, please check for existing or duplicate issues/PRs before opening your own to avoid doing work that may end up being rejected. For example if an issue is already open for a bug, you are welcome to comment on that issue requesting to be assigned (but this doesn't guarantee you will be the one assigned, so please don't open a PR unless you've actually been assigned first).

Since the existing issue has been assigned already, I will close this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants