Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Record Associations lesson: Fix grammar and spelling #28879

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Active Record Associations lesson: Fix grammar and spelling #28879

merged 2 commits into from
Oct 2, 2024

Conversation

jambalong
Copy link
Contributor

@jambalong jambalong commented Sep 30, 2024

Correct grammar and spelling: "is assume" to "is to assume" and "Often times" to "Oftentimes"

Because

This pull request addresses grammatical errors and spelling inconsistencies in the active_record_associations.md file. Specifically, it corrects "is assume" to "is to assume" for improved clarity and changes "Often times" to "Oftentimes" to ensure proper usage. These updates enhance the readability and professionalism of the lesson, making it easier for readers to understand the material.

This PR

  • Changes "is assume" to "is to assume" for grammatical correctness.
  • Replaces "Often times" with "Oftentimes" to adhere to proper spelling conventions.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Correct grammar and spelling: "is assume" to "is to assume" and "Often times" to "Oftentimes"
@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Sep 30, 2024
@JoshDevHub JoshDevHub self-assigned this Sep 30, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR @jambalong 🙌

While we're in this file, there are formatting errors with the codeblocks in this lesson. This wasn't anything you did, but before I merge, would you be okay fixing them?

Codeblocks should use 3 backtick characters ``` instead of 3 tilde characters ~~~. If you don't want to fix it, that's okay and I can go ahead and merge this as is. Just figured since we're already working on this file, we could potentially get that cleaned up as well. Let me know your preference.

Fix the formatting of code blocks throughout the documentation. It replaces the use of three tilde characters (~~~) with three backtick characters (```) to ensure proper rendering of code snippets.
@jambalong
Copy link
Contributor Author

@JoshDevHub
I have committed the fixes to the formatting errors for all code blocks in the lesson. The 3 tilde characters should now be replaced with 3 backtick characters to properly render the code snippets.

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that little problem. There are some other errors in this file that somehow weren't caught on first pass, but I don't want to make you fix things twice. So I'll just merge this.

Thank you for contributing.

@JoshDevHub JoshDevHub merged commit 61e55b9 into TheOdinProject:main Oct 2, 2024
1 of 2 checks passed
@jambalong jambalong deleted the patch-1 branch October 2, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants