Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int HTML & CSS : Added "which can be whatever name we want" #28829

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

devnchill
Copy link
Contributor

Because

When i was studying this lesson i got confused if the names of these variables are already predifned like css functions ? And i was thinking i'll have to learn the names of those variables . So I thought informing about the naming custom properties would help me as i won't be stressed thinking i'll have to learn it and instead have my own names variables if the follow the correct syntax.

This PR

  • Added "which can be whatever name we wan't" on line 33.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Sep 21, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original: #28800

You don't need to close a PR to make a change - you just need to commit and push any changes to that branch and it'll update the PR.

In this case, it seems an auto-formatter in your IDE has changed all of the * to \*, which must be changed back to *, i.e. get rid of the backslashes. When working on other public projects, make sure to disable any auto-formatters in your IDE in case it uses a different set of rules to what the project needs, like this one.

So you can just remove the backslashes, then commit and push to your namingcustomproperties branch then this PR will be updated with those changes.

@devnchill
Copy link
Contributor Author

Okay !

@devnchill
Copy link
Contributor Author

woah it worked like i just made changes to that branch and pr got updated as well ...

@MaoShizhong
Copy link
Contributor

Yep, that's all a PR is. It's a request to pull code from a branch (in this case, your namingcustomproperties branch from your fork) to another branch (main in the upstream repo). So it just tracks that branch as you make changes to it.

@MaoShizhong MaoShizhong merged commit 3d1f05c into TheOdinProject:main Sep 21, 2024
2 checks passed
@devnchill devnchill deleted the namingcustomproperties branch September 23, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants